Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to configure if detected errors raise or warn #3653

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

SteffenDE
Copy link
Collaborator

Adds a check for duplicate LiveComponents (Fixes #3650).

…Views

Adds a check for duplicate LiveComponents (Fixes #3650).
@SteffenDE
Copy link
Collaborator Author

This changes the default from warning to raising again, see #3603 and #3560.

@SteffenDE
Copy link
Collaborator Author

@josevalim I actually have to doublecheck what happens when there's a duplicate CID in another LiveView (which is allowed)

@SteffenDE
Copy link
Collaborator Author

@josevalim I actually have to doublecheck what happens when there's a duplicate CID in another LiveView (which is allowed)

double checked: 459fd49 prevents it. Perfect!

@SteffenDE SteffenDE marked this pull request as ready for review January 26, 2025 14:24
@SteffenDE SteffenDE force-pushed the sd-errors-raise-or-warn branch from a390842 to ed990cd Compare January 26, 2025 14:56
@SteffenDE SteffenDE force-pushed the sd-errors-raise-or-warn branch from ed990cd to b138418 Compare January 26, 2025 15:00
@SteffenDE SteffenDE merged commit 04aa842 into main Jan 26, 2025
16 checks passed
@SteffenDE SteffenDE deleted the sd-errors-raise-or-warn branch January 26, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No component for CID" error because of duplicate live components
2 participants